Remove unnecessary "Apply and Close" button from Properties dialog#4014
Merged
Conversation
Member
Shown "Close" instead of "Cancel" would even be better from my point of view. |
Contributor
elsazac
force-pushed
the
removeApplyandClose
branch
from
408812a to
6651650
Compare
Member
Author
|
This is the updated view with close option : 
|
This commit retains only the cancel button and eliminates the Apply and close button in the property dialog which is unnecessary in the current context there. There is only a description provided in the property dialog and there is no event that needs an apply option. Fixes: eclipse-equinox/p2#1049
elsazac
force-pushed
the
removeApplyandClose
branch
from
6651650 to
c8a2696
Compare
Member
Author
|
build looks good; merging this now; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Properties dialog opened from
Installation Details → Propertiesdoes not have any option to edit or make any modifications to the properties. Despite this it still displays bothCancelandApply and Closebuttons.Since no changes can be made in this dialog, the
Apply and Closebutton is basically redundant here and performs the same action asCancel. This could be confusing to the users hence this commit removes the unnecessaryApply and Closebutton and retain only thecanceloption.Fixes :eclipse-equinox/p2#1049
Before:
After:
